Telling if date format includes time

[JSJB]

Hello,

I am developing a custom visual that shows given columns of data and allows some data entry as well.

I am basing this datagrid on Material UI's datagrid component. However, this component has distinction between date format and date-time format.

I have implemented the valueformatting utilities in my project and the given format for a date measure works very well. However, as all values are in datetime, I am having difficulty determining if a given measure's format is datetime or only date.

I could do some inferencing on the format string that is given, but I'm curious if there isn't some other way of determining this?

Thanks in advance 🙂

[lbendlin]

Convert the datetime value to a number and check if it has fractions or not.

[JSJB]

Hello @lbendlin, thank you for your reply 🙂

I think your suggestion is good, but I am worried about performance of it. Because, to determine if something is a date format, we would theoretically need to evaluate every single value, would we not? If we check the first value and find it's a date, we can't exclude the possibility that the value after that may be datetime (and so on and so on). 

Either way, I've thought about it and believe that it's best to consider all date measures passed to be datetime. I will just include an option for users to specify if they want it to be date after the fact (while still using their formatting no matter what it is). I think this gives the end-user more flexibility.

Thanks for your help!